builder icon indicating copy to clipboard operation
builder copied to clipboard

update and lint fixes

Open gustavocodess opened this issue 3 years ago • 1 comments

Description

Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

Screenshot If relevant, add a screenshot or two of the changes you made.

gustavocodess avatar Aug 08 '22 14:08 gustavocodess

Needs a PR description, what does "update" mean here?

Dkendal avatar Aug 08 '22 15:08 Dkendal

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-vite-example ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 3:21PM (UTC)

vercel[bot] avatar Aug 16 '22 00:08 vercel[bot]

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 6ffa5402be6f9d235a69e4e8f3cd1ec27c8457c6 packages/sdks/e2e/tests/specs/data-bindings.ts View secret
- Generic High Entropy Secret 6ffa5402be6f9d235a69e4e8f3cd1ec27c8457c6 packages/sdks/e2e/tests/specs/symbols.ts View secret
- Generic High Entropy Secret 6ffa5402be6f9d235a69e4e8f3cd1ec27c8457c6 packages/sdks/e2e/tests/specs/symbols.ts View secret
- Generic High Entropy Secret 6ffa5402be6f9d235a69e4e8f3cd1ec27c8457c6 packages/sdks/e2e/tests/specs/symbols.ts View secret
- Generic High Entropy Secret 6ffa5402be6f9d235a69e4e8f3cd1ec27c8457c6 packages/sdks/e2e/tests/specs/symbols.ts View secret
- Generic High Entropy Secret 6ffa5402be6f9d235a69e4e8f3cd1ec27c8457c6 packages/sdks/e2e/tests/specs/symbols.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Aug 19 '22 13:08 gitguardian[bot]