budibase icon indicating copy to clipboard operation
budibase copied to clipboard

Allow customising links for exact roles

Open Elliot-Construct opened this issue 3 years ago • 11 comments
trafficstars

The new design layout links do not allow you to have different links for different users.

I have a few set to basic; and a few set to power... and if you are a power user you just see all of them! This is a bug and needs addressing

Elliot-Construct avatar Jul 18 '22 15:07 Elliot-Construct

Hey @Elliot-Construct. This is the way the links are supposed to work - the role is the minimum required role to view links, not the exact role. Notice the placeholder is named "Minimum role": image

For example:

  • Admins can view any links
  • Power can view power, basic, public
  • Basic can view basic, public
  • Public can view public

Choosing no role is the same as choosing "Public", in that anyone can see the links.

If you're after a feature where only one type of role (and no others) can see a certain link then I can update this ticket to be a feature request for that. Is that what you would like?

aptkingston avatar Jul 18 '22 15:07 aptkingston

It's a feature we had and now no longer have due to the new system. Please can you fix this.

It's way preferable to have to create links for each one.. now we are just limited to an undynamic set of links that clutter up the menu

Specifically for higher role users

Elliot-Construct avatar Jul 18 '22 16:07 Elliot-Construct

We've never had this feature - unless you mean using conditional UI on layouts to overwrite the links setting for each role. The new design makes it extremely fast and easy to solve most use cases - you can see additional, higher privilege pages if you have a higher role.

If you have a use case where you want a completely different set of links for users of different roles, you might be better to just disable the built in navigation completely and make your own (it's pretty simple - just a container and some links). You can very easily use conditional UI to show a certain set of links for a certain role, just like you used to do on the old design.

If we get other feedback that more people want this then we can consider adding a way to do this in the UI, but based on the feedback we had previously, the new system is exactly what was asked for. That's not to discredit your use case of course - which is why we can leave this open as a request and see if there is more demand for it.

aptkingston avatar Jul 18 '22 17:07 aptkingston

I'm talking about the fact you in the previous versions could have different navigational layouts for different pages which allowed you to set custom links for basic user pages and higher role pages respectively. (This was the specific purpose of the different layouts was it not?)

It doesn't seem like a big issue for you to change it from minimum role to specifically set which role sees what. [Correct me if I'm wrong]

It is a pretty big feature removed whichever way you look at it; So it's a bug that has been intended but that has a relatively simple logical fix that serves everybody's purpose and desire. [the logical operators used would be equals to ' = ' instead of greater than ' > ' ]

It comes across as just lazy using a minimum role when you could just as easily set it to the specific role only; it would just cause a little bit more work because you may have to build duplicate links for each role... but it allows for much higher levels of customization that pretty much all my apps are using at the moment, but now are depreciated to a much more simple and more cluttered system of one menu fits all...

Elliot-Construct avatar Jul 18 '22 18:07 Elliot-Construct

@mjashanks What's your take on this?

Elliot-Construct avatar Jul 18 '22 18:07 Elliot-Construct

Would you mind not changing the title please? I've renamed it to reflect the scope of work required to deliver the feature you are requesting. We would appreciate if you could also refrain from directly pinging team members.

As I mentioned previously, this feature was developed based on feedback, so while I appreciate that it does not serve your exact purpose ideally, it does for most people. This will stay open as a feature request and it can be implemented if there is demand for it.

Referring to this as a bug will not prioritise it, and neither will insulting team members and calling us lazy.

aptkingston avatar Jul 18 '22 19:07 aptkingston

It's lazy from the perspective of the development user. Because they won't have to create links for ALL of the roles manually. therefore it's a fix that reduces the features in favour of being lazy and having a quicker outcome. If you perceived it as a direct insult to the contributors of this project then you are mistaken.

Furthermore... This is a feature that has been removed [possibly, as you say, by popular opinion?] but you shouldn't be removing features and then telling me that they haven't been removed or that they never existed. You are then accusing me of being wrong or fabricating features which in turn is an insult to me.

Elliot-Construct avatar Jul 18 '22 20:07 Elliot-Construct

@Elliot-Construct - "being lazy and having a quicker outcome" is false and to be honest totally misplaced. A quicker outcome is the exact reason it was built in that fashion. It's not lazy to do work that isn't necessary for 90% of use cases - in fact it's inefficient to do so. As an open source project, we are always welcome to PRs and contributions, and you are always welcome to stay on an older version, or fork the repo and perform updates as you wish.

You were never accused of being wrong - in fact in the sentence directly after it was caveated by saying that custom layouts were the way to do this in previous versions.

Solutions have been offered - you can get rid of the navigation, and use a completely custom screen to build the same functionality - in fact, we even provided tools to allow you to do this more easily using your existing custom layouts and copy and paste.

I can also assure you @mjashanks, myself and the rest of the team were behind the decision to simplify and speed up budibase development as much as possible, as was much of our community.

This behaviour isn't helping anyone. We are always open to feedback - it's what drives the product and we appreciate all of it. I'm also not saying we aren't open to making a change here if it's something that is commonly requested and we can do so in a manner that makes sense for the product. What we are not open to is being dictated to and spoken to in that manner. Please stop changing the title, I'll have to lock the discussion on this issue to contributors if this childish behaviour continues.

shogunpurple avatar Jul 18 '22 22:07 shogunpurple

  • [x] A simple checkbox that changes it from minimum role to equals role shouldn't be too much to ask. Especially considering by not doing that you are excluding a minority of developers that according to your own estimates reach a huge 10% of use cases! Which is a large minority group.

A quicker outcome is the exact reason it was built in that fashion.

How is what you just said any different from what I said? I said it had been changed to favour a quicker outcome and less effort.

You were never accused of being wrong - in fact in the sentence directly after it was caveated by saying that custom layouts were the way to do this in previous versions.

This statement is hereby proven false by this specific comment below; (oh and thank you yet again for insinuating in a comment that I'm wrong):

We've never had this feature - unless you mean using conditional UI on layouts to overwrite the links setting for each role. The new design makes it extremely fast and easy to solve most use cases - you can see additional, higher privilege pages if you have a higher role.

Furthermore I was the person who wrote said caveat that you referred to in order to outline specifically why your colleague was incorrectly suggesting that I was wrong in my statement. (I'd appreciate it if you didn't try and use my own words in an attempt to reason that people were not inferring that I was wrong. Especially words meant to suggest the complete opposite)

Solutions have been offered - you can get rid of the navigation, and use a completely custom screen to build the same functionality - in fact, we even provided tools to allow you to do this more easily using your existing custom layouts and copy and paste.

This may be true however it's a temporary solution that radically reduces the design elements (You can't sticky header a container.) So it's a poor solution compared to previous features. and as for your tools.. I assume you are referring to the copy layout tool? That has absolutely no place in this discussion and is wholly irrelevant because I can't copy the links of the layout; therefore it's not worth mentioning [albeit a cool and useful tool for other use cases.]

Please stop changing the title

The title was changed by your colleague to "reflect the scope of work required to deliver the feature you are requesting"; I agreed with his specific concern here and only changed the title to further quantify the scope as well as the purpose

I am looking for a solution for all parties here, a solution that requires the minimum amount of contributor effort and you two have called me out for being incorrect when I'm not and accused me of insulting people when I haven't. (not to mention called me childish for trying to ensure that the "10 percenters" who are affected by this issue see this)

I request you return the title to what it previously was so the "10%" minority might find this issue more easily. [yes... I still say that this is an issue not an enhancement]. Oh and please stop being negative towards somebody who's trying to help you make Budibase better. Thank You.

Elliot-Construct avatar Jul 19 '22 01:07 Elliot-Construct

@shogunpurple bump

I request you return the title to what it previously was so the "10%" minority might find this issue more easily.

Elliot-Construct avatar Jul 20 '22 07:07 Elliot-Construct

This issue has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]

Closing in favour of: https://github.com/Budibase/budibase/issues/10645

melohagan avatar May 19 '23 09:05 melohagan