buddy_matching icon indicating copy to clipboard operation
buddy_matching copied to clipboard

fetch_last_solo_match/2 not guaranteed to return match from current season

Open ecly opened this issue 7 years ago • 0 comments

Queries for last solo queue match seem to be able to return games from last season, causing us to show potentially wrong results for border. This occurs in fetch_last_solo_match/2 in riot.api.ex, and is a somewhat special case bug.

This is currently only a problem for us early in a season, as we require players to have a match history from which we can deduce their last played champions and/or their border. If they have a match history, and their last solo queue game was from the last season, we will get a rank indication from 2 seasons ago.

Potential fixes:

  • Query API for season specific match
    • Requires some consistent way of getting current season id
    • (Riot currently has bug with bad season id's for matches making this inconsistent)

...

ecly avatar Feb 22 '18 17:02 ecly