2FAuth icon indicating copy to clipboard operation
2FAuth copied to clipboard

Cannot use SSO if app runs in subdirectory

Open bioschaf opened this issue 7 months ago • 1 comments

Version

5.2.0

Details & Steps to reproduce

If the app runs in a subdirectory (e.g. host.xy/subdir) the buttons on the login-page still point to host.xy/socialite/... resulting in errors.

Expectation

Buttons should use relative targets and in this example point to host.xy/subdir/socialite/...

Error & Logs

No response

Execution environment

No response

Containerization

  • [ ] Docker

Additional information

Can be fixes with the following patch

index 8b8bee52..6c246d1e 100644
--- a/resources/js/views/auth/Login.vue
+++ b/resources/js/views/auth/Login.vue
@@ -130,10 +130,10 @@
                     {{ $t('auth.or_continue_with') }}
                 </div>
                 <div class="column py-1">
-                    <a v-if="$2fauth.config.sso.openid" id="lnkSignWithOpenID" class="button is-link is-outlined is-small ml-2" href="/socialite/redirect/openid">
+                    <a v-if="$2fauth.config.sso.openid" id="lnkSignWithOpenID" class="button is-link is-outlined is-small ml-2" href="./socialite/redirect/openid">
                         OpenID<FontAwesomeIcon class="ml-2" :icon="['fab', 'openid']" />
                     </a>
-                    <a v-if="$2fauth.config.sso.github" id="lnkSignWithGithub" class="button is-link is-outlined is-small ml-2" href="/socialite/redirect/github">
+                    <a v-if="$2fauth.config.sso.github" id="lnkSignWithGithub" class="button is-link is-outlined is-small ml-2" href="./socialite/redirect/github">
                         Github<FontAwesomeIcon class="ml-2" :icon="['fab', 'github-alt']" />
                     </a>
                 </div>
@@ -171,10 +171,10 @@
                     {{ $t('auth.or_continue_with') }}
                 </div>
                 <div class="column py-1">
-                    <a v-if="$2fauth.config.sso.openid" id="lnkSignWithOpenID" class="button is-link is-outlined is-small mr-2" href="/socialite/redirect/openid">
+                    <a v-if="$2fauth.config.sso.openid" id="lnkSignWithOpenID" class="button is-link is-outlined is-small mr-2" href="./socialite/redirect/openid">
                         OpenID<FontAwesomeIcon class="ml-2" :icon="['fab', 'openid']" />
                     </a>
-                    <a v-if="$2fauth.config.sso.github" id="lnkSignWithGithub" class="button is-link is-outlined is-small mr-2" href="/socialite/redirect/github">
+                    <a v-if="$2fauth.config.sso.github" id="lnkSignWithGithub" class="button is-link is-outlined is-small mr-2" href="./socialite/redirect/github">
                         Github<FontAwesomeIcon class="ml-2" :icon="['fab', 'github-alt']" />
                     </a>
                 </div>

bioschaf avatar Jul 05 '24 10:07 bioschaf