FFmpeg-Builds icon indicating copy to clipboard operation
FFmpeg-Builds copied to clipboard

Feature Request: davs2-10bit

Open zhengqwe opened this issue 10 months ago • 8 comments

https://github.com/aliofwind/davs2-10bit I tried to integrate it in my fork but failed. I'm not sure if this is related to the upstream.

zhengqwe avatar Jan 31 '25 09:01 zhengqwe

Are you sure FFmpeg actually supports that? Cause there already is davs2, which is also already built here. That repo seems to be a fork of a fork of the davs2 I'm currently building.

BtbN avatar Jan 31 '25 13:01 BtbN

How to view ffmpeg configure log in ffbuild/config.log when using Github Action? https://github.com/zhengqwe/FFmpeg-Builds/actions/runs/13072737352

zhengqwe avatar Feb 01 '25 10:02 zhengqwe

Are you sure FFmpeg actually supports that?

Seem to be possible. https://github.com/xatabhk/FFmpeg-avs2-avs3 But it seems that there is no source code for compiling it, it just mentioned it used this

Cause there already is davs2, which is also already built here.

Yeah.

That repo seems to be a fork of a fork of the davs2 I'm currently building.

Yeah. The original davs2 ONLY supports 8bit videos, and does not support 10bit formats commonly used in 4K HDR videos. I'm not sure if the code here can be used normally, and more tests are required.

zhengqwe avatar Feb 03 '25 12:02 zhengqwe

That is a fork of FFmpeg, so adding that library here would not do any good, since I only build original upstream FFmpeg. You'd first need to get those patches upstreamed to FFmpeg.

Also, the only difference of that fork seems to be the addition of a libuavs3e based encoder? https://github.com/FFmpeg/FFmpeg/compare/master...xatabhk:FFmpeg-avs2-avs3:master

BtbN avatar Feb 03 '25 13:02 BtbN

Hope to add AVS2-10bit support

Fomalhaut6688 avatar Feb 04 '25 15:02 Fomalhaut6688

Again, I won't patch FFmpeg here. If you need a new feature like that, please first submit it upstream. It is still unclear to me if this doesn't just work. libdavs2.c in FFmpeg looks like it generally might support 10 bit? Are you sure it doesn't just work already?

BtbN avatar Feb 04 '25 15:02 BtbN

Hope to add AVS2-10bit support

Refer to my fork and https://github.com/xatabhk/FFmpeg-avs2-avs3 By the way, can anyone help me find the reason for building a failure? https://github.com/zhengqwe/FFmpeg-Builds/actions/runs/13072737352

zhengqwe avatar Feb 05 '25 03:02 zhengqwe

You are offering nonfree builds for download, that is a direct violation of the GPL. Please stop doing that.

Besides, the only apparent difference is you re-enabling vvenc, and said nonfree builds? https://github.com/BtbN/FFmpeg-Builds/compare/master...zhengqwe:FFmpeg-Builds:master

And again, I won't carry third party FFmpeg patches here. Get them upstreamed, and I can take a look at the necessary libraries here.

BtbN avatar Feb 05 '25 13:02 BtbN