Bryce-Huang
Bryce-Huang
> This happens on the version you built by yourself including this PR #490 ? Yes, but it doesn't matter. ```go func getServingImage(fn *openfunction.Function) string { if fn.Status.Revision == nil...
When the build is skiped, the `Revision.ImageDigest` still exist。
This problem will not occur if you specify the tag alone or use the source code to build alone.
Would it be better to not include the `Revision.ImageDigest` when calculating the serving hash? ```go func (r *FunctionReconciler) createServingSpec(fn *openfunction.Function) openfunction.ServingSpec { if fn.Spec.Serving == nil { return openfunction.ServingSpec{} }...
This PR is ready for review, it works for me well. ```yaml apiVersion: core.openfunction.io/v1beta2 kind: Function metadata: name: test-server spec: canarySteps: - weight: 20 pause: duration: 60 - weight: 80...
> @Bryce-huang Is this ready for review? Yes,I'm also doing tests.
> I would suggest the following changes: @Bryce-huang @wrongerror @wanjunlei @tpiperatgod @lizzzcai what do you think? > > ```yaml > apiVersion: core.openfunction.io/v1beta2 > kind: Function > metadata: > name: test-server...
functions spec: ```go CanarySteps []CanaryStep `json:"CanarySteps,omitempty"` ``` ```go type CanaryStep struct { Weight *int32 `json:"weight,omitempty"` Pause Pause `json:"pause",omitempty` } type Pause struct { // Duration the amount of time to...
> Hi @Bryce-huang maybe [Argo Rollouts](https://argoproj.github.io/rollouts/) is a better choice for canary and blue-Green Do you have any experience using cargo rollout on functions?
> yeah just a little with dapr and you reminded me. > > 1. Argo-rollout is used in Dapr 1.11 and 1.12. [Guidance for Blue Green deployments dapr/dapr#6855](https://github.com/dapr/dapr/issues/6855) > 2....