cigar icon indicating copy to clipboard operation
cigar copied to clipboard
verified publisher icon Brunty

Fixed type problems from Psalm level 2 - dont forget to follow spabby…

Open GeeH opened this issue 6 years ago • 7 comments

… at twitch.tv

GeeH avatar Oct 08 '19 13:10 GeeH

Thanks for this! Will take a look over it later on :)

Brunty avatar Oct 08 '19 13:10 Brunty

Coverage Status

Coverage remained the same at 100.0% when pulling df8442642f4332a932ead131abf0a9ac1b95f908 on GeeH:geeh/psalm-level-2 into daddcfd2a6344031398b016ee207ea91f5a078b7 on Brunty:master.

coveralls avatar Oct 08 '19 13:10 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling df8442642f4332a932ead131abf0a9ac1b95f908 on GeeH:geeh/psalm-level-2 into daddcfd2a6344031398b016ee207ea91f5a078b7 on Brunty:master.

coveralls avatar Oct 08 '19 13:10 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling ec7e5e0ebdda24b5e7b80dd12450529ae402a061 on GeeH:geeh/psalm-level-2 into daddcfd2a6344031398b016ee207ea91f5a078b7 on Brunty:master.

coveralls avatar Oct 08 '19 13:10 coveralls

Can this be added to travis so it runs in CI too?

Brunty avatar Oct 08 '19 13:10 Brunty

I guess, do you want me to make that change as part of this PR?

GeeH avatar Oct 10 '19 11:10 GeeH

@Brunty can't run as part of CI as Psalm depends on PHP 7.1 and therefore the 7.0 build fails. Would you be interested in PR that bumps to 7.3?

GeeH avatar Oct 10 '19 11:10 GeeH