cigar icon indicating copy to clipboard operation
cigar copied to clipboard

Connect and response timeout support

Open WyriHaximus opened this issue 7 years ago • 3 comments

Having both those time outs supported would be great. Running into an issue where it continues to wait for a requests that for some reason never completes

WyriHaximus avatar Dec 30 '18 16:12 WyriHaximus

Curl has CURLOPT_CONNECTTIMEOUT and CURLOPT_TIMEOUT so this should be fine to add. Just need to work out a test for it.

If we set defaults then allow them to be overridden with options, perhaps connect-timeout and timeout (need to work out short options too)

Thoughts @WyriHaximus? I'll add you as a collaborator too as you've been so helpful with this tool in the past :)

Brunty avatar Dec 30 '18 19:12 Brunty

Sure I'm game 👍 .

WyriHaximus avatar Dec 31 '18 11:12 WyriHaximus

@Brunty should the CLI option override the value configured in .cigar.json or the other way around?

WyriHaximus avatar Dec 31 '18 16:12 WyriHaximus