ScSR icon indicating copy to clipboard operation
ScSR copied to clipboard

the problem about the code

Open ypw1996 opened this issue 5 years ago • 4 comments

I think this position may be wrong. why is img_hr? I think it should be the low resolution image.

"img_lr_y_feat = extract_lr_feat(img_hr)"

ypw1996 avatar Nov 21 '19 12:11 ypw1996

In what line and file is the line you refer to? I plan on improving this code in the following weeks, as soon as I have some time. There's room to a lot of improvement.

BrunoVox avatar Dec 30 '19 19:12 BrunoVox

In what line and file is the line you refer to? I plan on improving this code in the following weeks, as soon as I have some time. There's room to a lot of improvement.

Line 55 in ScSR.py. I think we should extract the feature of the low resolution image, not the high resolution image. I try to modify it , but the code can't run.

ypw1996 avatar Jan 05 '20 06:01 ypw1996

I think that line should be

img_lr_y_feat = extract_lr_feat(img_us).

I'll report back when I try this.

mythrandire avatar Apr 21 '20 19:04 mythrandire

Yeah,I think so. Your code is the same as the original matlab version of the SCSR steps,clear and easy to understand. It helps me a lot. I’ m looking forward to your updated version.

---Original--- From: "mythrandire"<[email protected]> Date: Wed, Apr 22, 2020 03:41 AM To: "BrunoVox/ScSR"<[email protected]>; Cc: "ypw1996"<[email protected]>;"Author"<[email protected]>; Subject: Re: [BrunoVox/ScSR] the problem about the code (#2)

I think that line should be

img_lr_y_feat = extract_lr_feat(img_us).

I'll report back when I try this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ypw1996 avatar Apr 22 '20 02:04 ypw1996