deprecated-pokemongo-game-master icon indicating copy to clipboard operation
deprecated-pokemongo-game-master copied to clipboard

Add version script should run in docker

Open celandro opened this issue 7 years ago • 3 comments

It needs to work on my windows machine :)

It should not be hard to combine the build script and maven call into a single docker command

celandro avatar Dec 22 '17 01:12 celandro

What is the best way to do this for windows? I think for maintenance reason we should abandon Bash-Scripting and switch to something native like NodeJS or Java. So I think PowerShell would be a bad option? I prefer NodeJS because I'm used to it, but actually don't really care.

What's your opinion?

BrunnerLivio avatar Dec 22 '17 09:12 BrunnerLivio

I think run it in docker is fine. Literally same script but directly call maven and make sure the docker image has maven installed and it should work.

Different language is fine too but still a maven issue. Since it's already Java, writing it in Java would be the easiest

On Fri, Dec 22, 2017, 1:08 AM Livio Brunner [email protected] wrote:

What is the best way to do this for windows? I think for maintenance reason we should abandon Bash-Scripting and switch to something native like NodeJS or Java. So I think PowerShell would be a bad option? I prefer NodeJS because I'm used to it, but actually don't really care.

What's your opinion?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BrunnerLivio/pokemongo-game-master/issues/33#issuecomment-353555056, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX4gF3xLAPehpc6JnaGFRPXm0OjOgFDks5tC3F0gaJpZM4RKjal .

celandro avatar Dec 22 '17 15:12 celandro

Oh okay, now I understood it. I will probably not work on this in the next two weeks though...

BrunnerLivio avatar Dec 22 '17 17:12 BrunnerLivio