safe-compare icon indicating copy to clipboard operation
safe-compare copied to clipboard

[BREAKING] Drop support for Node <6.6.0

Open wojpawlik opened this issue 3 years ago • 4 comments

Makes the package tiny and dependency-free by removing ponyfills needed only by EOL Node.js.

#13 should be released first as 1.1.5.

wojpawlik avatar Mar 04 '21 11:03 wojpawlik

Coverage Status

Coverage remained the same at 100.0% when pulling bc98a8ca87b10c29d1f19847067e720edb66ec73 on wojpawlik:drop-old-node into ad212fca6e4de5b5990c4a8e633e5fe0fe602884 on Bruce17:master.

coveralls avatar Mar 04 '21 11:03 coveralls

I have one doubt with only using the native timing method: performance. The benchmark tests return a bad performance for the native method using Buffer.alloc and a even worse performance using Buffer.allocUnsafe.

Therefore I have to validate the benchmark itself first and then decide on how to continue here.

Any comments on that @Drexonom ?

Bruce17 avatar Mar 04 '21 12:03 Bruce17

How can I see the benchmark results? npm run posttest outputs nothing.

wojpawlik avatar Mar 04 '21 14:03 wojpawlik

Matcha in Posttest ist broken for newer Node.js versions. I just tested it with some different performance testing libraries. Maybe I can upload an example soon.

Bruce17 avatar Mar 04 '21 18:03 Bruce17