Waterfox icon indicating copy to clipboard operation
Waterfox copied to clipboard

Fix geolocation api setting always showing as enabled

Open LAURAilway opened this issue 1 year ago • 1 comments

The radio buttons didn't correctly detect "" as a value, so the geolocation setting always appeared as "enabled" on reload, regardless of actual state. Setting the string for "disabled" to " " seems to fix the issue. I am not entirely sure if this is bad practice for whatever reason, I defer that judgement to you. Closes #3441

LAURAilway avatar Jun 26 '24 01:06 LAURAilway

Note: Setting it to about:blank (or any other non-empty string that isn't a valid url) also works, if that would be preferable for easier maintenance

LAURAilway avatar Jun 26 '24 14:06 LAURAilway

https://github.com/BrowserWorks/Waterfox/commit/4a07e9784069ce21ba99876774753e4e8d605c77

MrAlex94 avatar Jul 02 '24 12:07 MrAlex94