Waterfox icon indicating copy to clipboard operation
Waterfox copied to clipboard

Translate "Open in new private tab" and more words in options

Open kamil445 opened this issue 2 years ago • 12 comments

Is your feature request related to a problem? Please describe. Is there a option to translate this ? Also in Options some words is not translated.

Describe the solution you'd like Update polish translation, translate all untranslated words. I can translate but can't find where i can do that.

Describe alternatives you've considered Another way to translate it manually, via userchrome.css or something...

Additional context screen: https://i.imgur.com/ayJEeLZ.png

kamil445 avatar Apr 06 '22 10:04 kamil445

Hi @kamil445 - Want to say thank you for offering to translate, if you take a look at this pull request you can see how translations were done for Japanese, the same principle will apply for Polish.

https://github.com/WaterfoxCo/Waterfox/pull/2615/files

adamp01 avatar Apr 07 '22 07:04 adamp01

I don't know how comfortable you are doing pull requests etc. so I can always send you a list of things that need translating and can then add it to the browser on your behalf, let me know.

adamp01 avatar Apr 07 '22 07:04 adamp01

I don't know how comfortable you are doing pull requests etc. so I can always send you a list of things that need translating and can then add it to the browser on your behalf, let me know.

I updated Translation and my pull request is here https://github.com/WaterfoxCo/Waterfox/pull/2666

I can't find a way to translate this https://i.imgur.com/Jvor2ra.png In Waterfox Classis this was translated in this file "\browser\chrome\pl\locale\browser\browser.properties" line "restartPromptQuestion.label".

kamil445 avatar Apr 08 '22 11:04 kamil445

Perfect - I've got a PR that will be merged shortly that will allow all the translations to be put into the extensibles.ftl file.

I'm actually going to move the restart prompt localisation into extensibles.ftl as well. So you could add the translations to extensibles.ftl under restart-prompt-question and restart-prompt-title in preparation for that change.

adamp01 avatar Apr 08 '22 11:04 adamp01

Thank you,

I added restart-prompt-title and restart-prompt-question. Should i add %S like in waterfox classic ? restartPromptTitle.label = Restart przeglądarki %S restartPromptQuestion.label = Czy na pewno chcesz ponownie uruchomić przeglądarkę %S? or just replace %S with Waterfox what i've already done in pull request ?

kamil445 avatar Apr 08 '22 13:04 kamil445

Ah no - in this case it would be { -brand-short-name }

Thanks for sorting this!

adamp01 avatar Apr 08 '22 13:04 adamp01

Okey, i changed Waterfox to { -brand-short-name }

kamil445 avatar Apr 08 '22 17:04 kamil445

Maybe Crowdin or some another localization service would be better for translators (#1412).

hawkeye116477 avatar Apr 11 '22 14:04 hawkeye116477

Thanks @hawkeye116477 - we've set this up now that we are going to be pushing for more translations. I'll post to Reddit once everythings set.

adamp01 avatar Apr 11 '22 15:04 adamp01

@hawkeye116477 - If you take a look here, can you access strings that require translation still? https://crwd.in/waterfox

adamp01 avatar Apr 11 '22 16:04 adamp01

@adamp01 Yes, I can.

hawkeye116477 avatar Apr 12 '22 13:04 hawkeye116477

This message also can be translated ?

https://media.askvg.com/articles/images7/Firefox_Already_Running_But_Not_Responding_Error_Message.png

kamil445 avatar May 01 '22 09:05 kamil445