YAGSL-Example
YAGSL-Example copied to clipboard
BroncBotz3481
Integration of AdvantageKit
I was wondering if there had been any thoughts of integrating advantagekit into YAGSL, I'd even be willing to contribute to it and use my team's bot to test it if necessary.
I think it's something that would be really cool to incorporate into YAGSL.
I haven't looked into Advantage Kit but I've heard it complicates the robot project. YAGSL sits in a difficult spot. It should be easy to get into and modify but have a high enough ceiling that a more advanced team can get more performance out of it.
I still am just looking into it for the first time, but it certainly does complicate a lot of stuff. Although I think it could end up being harder having it set up in a way that doesn't force the team to use advantagekit
That is my conclusion as well, I have talked with the AdvantageKit devs before about it and we have concluded YAGSL is possible to integrate into AdvantageKit however it would require users to call functions synchronously with periodic's and modify the SwerveTelemtry too. I dont think its worth adding bc i want YAGSL to remain first and foremost, a library NOT a template.
If you don't mind then, I may fork YAGSL and mess with implementing it myself
Go ahead, and Good luck! Its a pain maintaining a fork though but itd be a good reference for teams.
I'd like to reopen this issue now that AdvantageScope is an official WPILIB Tool. I feel like it should be pretty basic to implement just a basic SwerveDriveIO Class, since a lot of abstraction is already done for motors and the like
AdvantageScope != AdvantageKit however it is a consideration I still do not want the user to have to do anything other than include the library.
This is being worked on as a PR, not by us. The PR has an idea and will be reviewed and merged provided advantagekit-less projects still function
Which PR is this? I didn't see it in the list, but I may have just missed it. I'd love to take a look.
