canute-ui icon indicating copy to clipboard operation
canute-ui copied to clipboard

Popup "done" at the end of the line when inserting bookmarks

Open kasbah opened this issue 7 years ago • 3 comments

When inserting bookmarks within the home menu "done" can popup at the end of the line to provide feedback that a bookmark was inserted.

kasbah avatar Aug 10 '17 14:08 kasbah

I'll take this one. Will create an initial PR shortly

Lazarus404 avatar Jul 28 '18 05:07 Lazarus404

@pachpict Clarifying:

  • popping up text obviously doesn't work if a sly user presses the bookmark key directly while a book page is showing
  • assuming the intention was to have INSERT BOOKMARK AT CURRENT PAGE change into INSERT BOOKMARK AT CURRENT PAGE ... DONE: there's not a huge amount of space at the end of that line in Grade 1 mode (just enough, really); and in other languages there may not be enough

So I could add this as a display change, but perhaps it should (become dependent upon and) use the vibration motor instead to be more consistent? We'd have to bump up the priority of vibration motor support, of course, so it would take longer.

zwbrbr avatar May 09 '19 09:05 zwbrbr

@pachpict Bump. Need to decide on the detail.

zwbrbr avatar Sep 17 '19 10:09 zwbrbr