gruvbox-atom icon indicating copy to clipboard operation
gruvbox-atom copied to clipboard

some coloring inconsistencies in SCSS files

Open smlombardi opened this issue 9 years ago • 2 comments

  • note the first 3 commas on color and the last is white.
  • The alpha value in the rgba color is magenta if it's 0 but green if its something else.
  • hyphenated propetry in transition has a magenta hyphen
  • this is minor and probably not worth it, but the digit in the transition timing is white while other digits in property values are magenta.

screen shot 2016-06-01 at 1 34 34 pm

smlombardi avatar Jun 01 '16 17:06 smlombardi

Unfortunately these are a result of improper syntax scoping and would best be fixed by the maintainers of Atom's syntaxes.

  1. the commas should be white, but not all of them are scoped so I can't color them consistently
  2. Certain RGB Alpha values are given an incorrect variable.parameter.url.scss scope. This scope is correctly colored green, but should not be applied in this instance.
  3. The hyphen is scoped as support.constant.mathematical-symbols.scss which is correctly colored as purple, but again, improperly scoped.
  4. Numbers in this case are not given any scope, so I can't color them.

For cases like this I typically mask the improper scoping but for these specific cases I cannot because of the lack of scope specificity.

Briles avatar Jun 01 '16 18:06 Briles

He has apparently fixed this in langugage-sass: https://github.com/atom/language-sass/pull/152

smlombardi avatar Jul 17 '16 20:07 smlombardi