BMPlayer icon indicating copy to clipboard operation
BMPlayer copied to clipboard

BMPlayerConf is not working

Open O-mkar opened this issue 7 years ago • 2 comments

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

BMPlayer version

1.0.1

Installed with

  • [ ] Carthage
  • [x] Cocoapods

Issue Description

BMPlayerConf nothing is working

What

[Tell us about the issue]

Reproduce

     BMPlayerConf.enablePlaytimeGestures = false

    let controller = BMPlayerCustomControlView()

    
    player = BMPlayer(customControlView: controller)
    videoPlayerView.addSubview(player)
    player.snp.makeConstraints { (make) in
        make.center.equalTo(videoSuperView)
        make.width.equalTo(videoSuperView)
        make.height.equalTo(videoSuperView)
    }

    player.delegate = self

    let asset = BMPlayerResource(url: URL(string: "URL")!,
                                 cover: URL(string: "URL"))
    
    player.setVideo(resource: asset)
    player.pause(allowAutoPlay: false)

[The steps to reproduce this issue. What is the URL you were trying to play, where did you put your code, etc.]

Other Comment

[Add anything else here]

O-mkar avatar Apr 07 '18 12:04 O-mkar

I also cannot get the following to work:

BMPlayerConf.enableVolumeGestures = false
BMPlayerConf.enableBrightnessGestures = false

laus102 avatar May 22 '18 22:05 laus102

The fix for this is added in 0524fadd7c70b4a6ef0f47e72ddfbf38e59a8d79 commit. Since there are no releases after that, you wont be getting this code. If you really want this to be solved use below code in pod file

 pod 'BMPlayer', :git => 'https://github.com/BrikerMan/BMPlayer.git', :commit => '0524fadd7c70b4a6ef0f47e72ddfbf38e59a8d79'

talk2cerlin avatar Dec 03 '18 07:12 talk2cerlin