Brighter icon indicating copy to clipboard operation
Brighter copied to clipboard

Add support for Postgres Locking

Open lillo42 opened this issue 1 year ago • 2 comments

  • Add support for Postgres Locking

lillo42 avatar May 21 '24 09:05 lillo42

@lillo42 Sorry for the delay on this one, there has been a small change in the interface at the behest of a feature request please see #3113 Sorry for any inconvenance

preardon avatar May 28 '24 07:05 preardon

@preardon sure, no problem, when that PR is merged to v10 I'll update it

lillo42 avatar May 30 '24 11:05 lillo42

@preardon @lillo42 Where are we on this one?

iancooper avatar Jul 07 '24 14:07 iancooper

@iancooper I,we got a task to kill the non Async methods for the interfaces, @lillo42 I'm happy to update your branch when I do it if you'de like.

@iancooper do you think it's worth me doing a Relational Database abstraction for this too?

preardon avatar Jul 07 '24 14:07 preardon

@iancooper I,we got a task to kill the non Async methods for the interfaces, @lillo42 I'm happy to update your branch when I do it if you'de like. Wonder if that would be simpler?

@iancooper do you think it's worth me doing a Relational Database abstraction for this too?

It could be a good idea, the more we push down I think the easier it is to own; it cost us a lot to keep stuff in the individual rdbms implementations

iancooper avatar Jul 07 '24 14:07 iancooper

@lillo42 I'm happy to do the updates to this branch for you, just let me know. Also do you want this backport into v9?

preardon avatar Jul 14 '24 17:07 preardon

Going to merge this.

iancooper avatar Jul 17 '24 14:07 iancooper

Hi @lillo42 this fails tests. Can you take a look?

[Paramore.Brighter.PostgresSQL.Tests.Inbox.SqlInboxEmptyWhenSearchedAsyncTests.When_There_Is_No_Message_In_The_Sql_Inbox_And_I_Check_Exists_Async [46 ms] Failed Paramore.Brighter.PostgresSQL.Tests.PostgresLockingProviderTest.GivenAnPostgresLockingProviderWithALockedBlob_WhenReleaseLockIsCalled_ItCanOnlyBeLockedAgain [96 ms] Error Message: Assert.Null() Failure: Value is not null Expected: null Actual: "TestLock-a07603ed-64c2-4557-be2a-e022a046d72d" Stack Trace: at Paramore.Brighter.PostgresSQL.Tests.PostgresLockingProviderTest.GivenAnPostgresLockingProviderWithALockedBlob_WhenReleaseLockIsCalled_ItCanOnlyBeLockedAgain() in /home/runner/work/Brighter/Brighter/tests/Paramore.Brighter.PostgresSQL.Tests/PostgresLockingProviderTest.cs:line 47

iancooper avatar Jul 17 '24 19:07 iancooper

@iancooper sure, no problem

lillo42 avatar Jul 19 '24 13:07 lillo42