rcv icon indicating copy to clipboard operation
rcv copied to clipboard

Checkstyle warnings in GuiConfigController.java

Open NCGThompson opened this issue 4 years ago • 1 comments

To see these warnings run ./gradlew checkstyleMain or gradle checkstyleMain. I found a fix for the third warning. The others are due to left curly brackets being on a wrapped line. I tried a few things to please Checkstyle but they all caused a different error. The is probably a way to comply with the style guidelines, but if not the warnings should be silenced.

The offending blocks are lines 969 - 972 and lines 991 - 998.

NCGThompson avatar May 19 '21 19:05 NCGThompson

Thanks for this. I typically only bother with addressing Checkstyle as the very last step of preparing for a release because it's so finicky and is a pain to deal with especially when the code is in flux (plus recommendations can change as new versions of Checkstyle and the Google style recommendations come out).

I'll go ahead and approve your PR for this now, but I'd say don't worry about the other ones... I'll keep this issue open as a reminder to take another stab at it during our next release.

HEdingfield avatar May 28 '21 22:05 HEdingfield