rcv icon indicating copy to clipboard operation
rcv copied to clipboard

Add source files with multiple contests (contestIds) to test that this is handled properly

Open HEdingfield opened this issue 5 years ago • 13 comments

HEdingfield avatar Jul 25 '20 21:07 HEdingfield

@chughes297 or @gngilbert, would you mind putting together something like this for us? Clear Ballot would probably be easiest, but if we could get them for Dominion and Hart too, that'd be a bonus.

HEdingfield avatar Jul 28 '20 03:07 HEdingfield

Ideally we would construct a single test that has one source from each of the non-CDF providers we support (Clear Ballot, Dominion, Hart, ES&S)!

tarheel avatar Jul 28 '20 06:07 tarheel

By "source files" I presume you mean test data sets. Can you point me to the current files you have tested for Clear Ballot, Dominion and Hart so that I will know that I am working off of the same versions you are?

gngilbert avatar Jul 28 '20 18:07 gngilbert

They're here under the clear_ballot_*, dominion_*, and hart_* folders, respectively.

HEdingfield avatar Jul 28 '20 19:07 HEdingfield

Thanks.

On Tue, Jul 28, 2020, 3:23 PM HEdingfield [email protected] wrote:

They're here https://github.com/BrightSpots/rcv/tree/develop/src/test/resources/network/brightspots/rcv/test_data under the clear_ballot_, dominion_, and hart_* folders, respectively.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BrightSpots/rcv/issues/477#issuecomment-665230097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJODE7VKMPEROLQ74JGJPHTR54QS3ANCNFSM4PHUU6XA .

gngilbert avatar Jul 28 '20 21:07 gngilbert

Sorry but I am unfamiliar with GitHub and can't figure out how to download a file to my laptop. Assuming that is what I need to do. (Starting with Clear Ballot)

George Gilbert RCV Resource Center [email protected] 336-906-0047

On Tue, Jul 28, 2020 at 3:23 PM HEdingfield [email protected] wrote:

They're here https://github.com/BrightSpots/rcv/tree/develop/src/test/resources/network/brightspots/rcv/test_data under the clear_ballot_, dominion_, and hart_* folders, respectively.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BrightSpots/rcv/issues/477#issuecomment-665230097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJODE7VKMPEROLQ74JGJPHTR54QS3ANCNFSM4PHUU6XA .

gngilbert avatar Jul 29 '20 17:07 gngilbert

Ok. I got the cvr.csv for the kansas primary for Clear Ballot. Is this the only file I need to work with to create a test data set for Clear Ballot?

Looking back at the first set of Clear ballot test files we got (10/31/19), I see four additional files: choices.csv, contest.csv, precincts.csv and parties.csv. ??

gngilbert avatar Jul 29 '20 19:07 gngilbert

@moldover can best answer these questions.

tarheel avatar Jul 29 '20 20:07 tarheel

It'd be nice to have a CDF JSON (and XML once that's in), with multiple contests too.

HEdingfield avatar Aug 03 '20 16:08 HEdingfield

@gngilbert: Yes, you only need the cvr file. The additional files are useful for verification. We can also add a feature to slurp up the candidates (choices) data from the choices file automatically so the user doesn't have to enter them manually into the config.

You can use the Kansas csv as a starting point to create a multi-contest cvr: by extending the columns with a new contest. The column headers would look like My_Choice_ID:My_Contest_ID:Rank:Vote For 1:Candidate_ID:Party_ID.

moldover avatar Aug 05 '20 14:08 moldover

Okay. Thanks. I will give it a try.

On Wed, Aug 5, 2020, 10:02 AM Jon Moldover [email protected] wrote:

@gngilbert https://github.com/gngilbert: Yes, you only need the cvr file. The additional files are useful for verification. We can also add a feature to slurp up the candidates (choices) data from the choices file automatically so the user doesn't have to enter them manually into the config.

You can use the Kansas csv as a starting point to create a multi-contest cvr: by extending the columns with a new contest. The column headers would look like My_Choice_ID:My_Contest_ID:Rank:Vote For 1:Candidate_ID:Party_ID.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BrightSpots/rcv/issues/477#issuecomment-669211682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJODE7T5M7JLFSRXOUR3CE3R7FQ6ZANCNFSM4PHUU6XA .

gngilbert avatar Aug 05 '20 18:08 gngilbert

have we made any progress on this? or do we need to pick this back up? we do need this feature (not realistic for 1.3.0 but would be good to have for next version)

chughes297 avatar Aug 08 '22 14:08 chughes297

We support this, right? I think this issue is just flagging that we need to have an automated test to confirm that it works. @moldover should have better context here.

tarheel avatar Aug 08 '22 18:08 tarheel