rcv icon indicating copy to clipboard operation
rcv copied to clipboard

GUI falsely reports that invalid config is unsaved

Open tarheel opened this issue 6 years ago • 3 comments

Repro:

  • Load invalid_params_test_config.json
  • Click the Load button again. It will ask if you want to save your changes, even though you didn't change anything.

tarheel avatar Jun 09 '19 02:06 tarheel

Turns out I had documented this a while back in a local notes file I had:

  • BUG: if you create a config with just a title and save it, it'll automatically input a value for output path, so if you load it and try to do something without changing it it'll think it was changed

I think what's actually causing this is, when there's no outputDirectory defined in the config JSON, it'll automatically put the local directory it's saved to in the input box in the GUI.

HEdingfield avatar Jun 19 '19 22:06 HEdingfield

This doesn't seem to repro for me anymore. Well, it does repro when I first load it, but once I save the file once and it reformats it, it's fine from then on. So I'll just put up a PR with that updated version.

tarheel avatar Jul 07 '19 06:07 tarheel

I suggest we close this because I understand why it happens, and it makes sense to me. Basically, if you have garbage parameters like "oogabooga" for tiebreakMode or any other enums, it'll silently replace that with "modeUnknown". I guess we could consider adding a warning message to the user during loading notifying them about this, but I don't know that it's super important. Will leave it open in case we want to do that.

HEdingfield avatar Jul 07 '19 19:07 HEdingfield