Ruben Bridgewater

Results 323 comments of Ruben Bridgewater

I have no strong opinion either way.

I use something in my own modified bash script and it is indeed nice that way :-) ```bash COMMITS=$(git rev-list --count master...upstream/master) # Copy the message for the PR to...

We should also automatically check if local master branch is already up to date and skip the suggestion (`Do you want to try reset the local master branch to upstream/master?...

Another improvement would be to ask if the user wants to push the commit (`To finish landing: 1. Run git push upstream master`). That way there's one less command to...

@Salakar you assigned this to yourself, do you still want to have a look at it?

I think strings that clearly represent an integer should continue to be supported as well as it would otherwise unnecessarly disrupt many users. The following should pretty much be accepted:...

@devoidfury the reason is that it's not possible to know if and when the handler is actually attached. Attaching the handler could in fact fail as well. Imagine `wait()` would...

Yes, it is indeed a limitation in detecting such cases. About telling the reason: it's an error, just as any other error in the application. We do not log extra...

Here is a short benchmark (the second one is with the regular expression): ![image](https://user-images.githubusercontent.com/8822573/146613379-72ff0b16-7c1c-42ef-bb1b-e7f81e3fb04a.png) util.inspect is not only used for debugging. It is in fact used in a lot of...

We discussed such performance tests before but they would have to verify too many cases and take too long to be run regularly. We do have benchmarks in place to...