Ruben Bridgewater comments

Results 149 comments of


                                            Ruben Bridgewater

make decirc function public

I agree that moving the decirc function to a separate module will be best in this case. It will definitely not hurt one way or the other and if there...

inspect: fix console.log(%s, { [Symbol.toPrimitive]: () => hello })

Hey @Ch3nYuY, the recent commits block the PR from being merged. Can you please rebase? :)

Update stuff

@iarna PTAL

Set and Map performance and correctness

I can not promise that I have time for that anytime soon. I have a couple of things that I am working on at the moment.

Set and Map performance and correctness

@keithamus ```js deepEql(new Set([1, 2]), new Set([2, 1])) // passes ``` This is highly inconsistent to the object version and about Sets being ordered - it is true that it...

Set and Map performance and correctness

I personally do not have a use case at hand as I personally never needed to compare sets or maps. But in general I can imagine that people just want...

Set and Map performance and correctness

@keithamus about performance concerns: this is indeed bad. I would probably do a feature detection in this case. That should be easy. Another way to improve the performance for `forEach`...

path: fix win32.relative() for some Unicode paths

Superseded by another PR

net: support passing a host with port to Server.prototype.listen

@Zirak is it intentional that this is kept as draft?