Ruben Bridgewater

Results 149 comments of Ruben Bridgewater

The current implementation for the diff is a quick best effort implementation and we have to change it to Myers algorithm or similar to properly detect these changes without a...

@chenyuyang2022 no, the `hasBuiltInToString` method has to check for for the `toPrimitive` symbol as well. Please always run the tests as well. There should be test failures related to the...

@Ch3nYuY thank you for following up on the comments!

@Ch3nYuY seems like there is a linter error that has to be resolved before it's possible to land this

This mainly requires more fine granular suggestions. Regular expressions can definitely be handled better and this also applies to e.g., not suggesting top level modules as property (`/a/.dg`).

@zz0808 the issue is that `util.inspect()` uses a depth first algorithm and it would have to switch to a width first algorithm. That's not a trivial undertaking though to rewrite...

Node.js is already kind of redacting some error frames. It's done by using the non standard `Error.captureStackTrace()` function. The full stack of the error is probably still available when using...

@masmu is there any update on this? Is there any blocker for the current master being released as 0.53?

It seems the decycling breaks the mongoose `toJSON` function. It could be that the function was replaced in case it's cyclic. But that should not break mongoose, since `JSON.stringify` works...

@filetvignon great! It is out there for quite some time and it should be very stable. I would actually call it safer to use since it has less special handling...