Brian Henry

Results 134 comments of Brian Henry

There's a few options here. 1. Your existing WIP, https://github.com/wp-cli/wp-cli/compare/main...baizmandesign:wp-cli:feature/plugin-update-info-261, needs to check `isset( $this->plugin_info )` because that array doesn't seem to be available during a plain `wp plugin install...

I'm not saying it _should_, I was just noting that when testing that array was not available, so needs to be guarded against.

I worked on this again yesterday. I'll be testing this change: https://github.com/WPTT/admin-notices/compare/master...BrianHenryIE:admin-notices:fix-race-condition-%2314 The changes are mostly: * Use `jQuery( function() {` rather than `window.addEventListener( 'load', function() {` * Use `wp_add_inline_script`...

Because of #18 I'm now using an unpatched version of the library and can confirm the issue is still present with Firefox.

I think I need to move the call to the previous error handler to before the filter so it is always run. Currently the filter could short-circuit and return true...

This was discussed https://github.com/nielsmouthaan/ejectify-macos/issues/19#issuecomment-1283754952 and rejected so I wrote: https://github.com/BrianHenryIE/UnmountVolumeAfterTimeMachine

Letting the JIT compile run does work, but takes 20 minutes and **runs every time.** I tried explicitly _not_ disabling the cache, but it didn't work to avoid the recompile...

Current differences between `mac.yml` and this `mac-arm64.yml` are now only: * `kivy` is installed through `pip` * `tensorflow==2.9` becomes `tensorflow-macos==2.9` * `tensorflow-metal==0.5.0` is added. If only `tensorflow-metal` is specified the...

This is a good idea, given the current codebase. I think we should open an issue, something like ~"TODO: fix PHPCS exclusions". Then hopefully we'll see PRs for each item...

I started work on the RPC client classes to get them strongly typed and unit tested. https://github.com/BrianHenryIE/bh-php-monero-daemon-rpc I'll do more work on it as the mood takes me. Hopefully will...