BrianGun

Results 45 comments of BrianGun

If you want to get all the glasses in the glass catalog you can use this function: GlassCat.AGF_GLASSES this is a vector of glasses. If you do glasses = GlassCat.AGF_GLASSES...

the redefinition of T on L85 is redundant but shouldn't affect correctness. Should be deleted. I'll ask Joel to measure a light spectrum for us that we can use as...

Agreed this needs to be fixed. It will take a bit of time to figure out how to restructure the code. @cdhf your deterministic ray tracing example was very nice....

Detectors are currently handled specially in the trace function defined for CSGOpticalSystems (src/Optical/OpticalSystem.jl line 100). Each CSGOpticalSystem object stores a detector, which is just a Surface, and a detectorimage. The...

@cdhf that is an intriguing idea. Shouldn't be that hard to do. Let me noodle on it for a day and then we should be able to nail down exactly...

Great, I've been thinking about how to do this and it looks like there is a way that won't require major changes to the code but will give you, and...

How about something like this? ``` abstract type AbstractDetector end """interface for AbstractDetector """ surface(a::AbstractDetector) #returns the surface contained in the Detector update!(a::AbstractDetector, b::LensTrace) #update the detector object with the...

@cdhf I like your naming suggestion. But I'm leery of detectors indexing on user supplied name fields unless we have some way of guaranteeing that the name fields are unique....

@cdhf your observation about using attenuated power if we implement raysplitting is correct. Looking over the code you submitted in PR #63 exactly this type of error seems to have...