HEMTT icon indicating copy to clipboard operation
HEMTT copied to clipboard

sqf: Inspector

Open PabstMirror opened this issue 1 year ago • 2 comments

  • Type checking
  • Var Usage (Undefined, Not Private, Shadowing and Unused)

PabstMirror avatar Sep 26 '24 07:09 PabstMirror

Codecov Report

:x: Patch coverage is 81.50488% with 322 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 69.0%. Comparing base (68c03f5) to head (c71d8d3). :warning: Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libs/sqf/src/analyze/inspector/commands.rs 77.1% 82 Missing :warning:
...bs/sqf/src/analyze/inspector/external_functions.rs 73.7% 43 Missing :warning:
libs/sqf/src/analyze/inspector/game_value.rs 79.0% 39 Missing :warning:
libs/sqf/src/analyze/lints/s16_not_private.rs 73.1% 29 Missing :warning:
libs/sqf/src/analyze/inspector/mod.rs 93.6% 24 Missing :warning:
libs/sqf/src/analyze/lints/s25_count_array_comp.rs 76.2% 24 Missing :warning:
libs/sqf/src/analyze/lints/s14_unused.rs 78.8% 22 Missing :warning:
libs/sqf/src/analyze/lints/s13_undefined.rs 80.9% 20 Missing :warning:
libs/sqf/src/analyze/lints/s15_shadowed.rs 79.1% 20 Missing :warning:
libs/sqf/src/analyze/lints/s12_invalid_args.rs 80.0% 19 Missing :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
...s/config/src/analyze/lints/c13_config_this_call.rs 74.2% <100.0%> (ø)
...preprocessor/src/codes/pe15_if_invalid_operator.rs 84.6% <100.0%> (+1.2%) :arrow_up:
libs/preprocessor/src/codes/pw1_redefine.rs 100.0% <100.0%> (ø)
libs/preprocessor/src/codes/pw3_padded_arg.rs 100.0% <100.0%> (ø)
libs/preprocessor/src/processor/directives.rs 92.5% <100.0%> (+<0.1%) :arrow_up:
...s/sqf/src/analyze/lints/s07_select_parse_number.rs 68.1% <100.0%> (+0.5%) :arrow_up:
libs/sqf/src/analyze/lints/s08_format_args.rs 77.9% <100.0%> (+0.4%) :arrow_up:
...s/sqf/src/analyze/lints/s21_invalid_comparisons.rs 75.4% <100.0%> (-0.3%) :arrow_down:
libs/sqf/src/analyze/lints/s22_this_call.rs 74.1% <100.0%> (ø)
...rc/analyze/lints/s23_reassign_reserved_variable.rs 79.7% <ø> (-0.4%) :arrow_down:
... and 18 more

... and 25 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 26 '24 07:09 codecov[bot]

I was also working on something like this, and using the type information from the wiki.

I'm not a fan of it being one big piece that is a single lint

BrettMayson avatar Sep 26 '24 15:09 BrettMayson

Now that we have pedantic, are there pieces of this that can brought into HEMTT with that? Or some parts of this PR that can make it in while others are behind an experimental flag?

BrettMayson avatar Mar 11 '25 00:03 BrettMayson

I think it is time to get this merged

If you think anything should be enabled / moved to pendantic, or put behind an experimental flag let me know

BrettMayson avatar Sep 27 '25 09:09 BrettMayson

this probably could use some more polish and stuff, and better wiki data >:|

but fuck it we ball

BrettMayson avatar Sep 30 '25 20:09 BrettMayson