HEMTT icon indicating copy to clipboard operation
HEMTT copied to clipboard

Make signing a separate step

Open bovine3dom opened this issue 6 years ago • 6 comments
trafficstars

I often re-sign third party modifications who don't change their private key with each version to prevent people joining with old versions.

Could we separate signing out into a separate command so I can repurpose HEMTT for this?

bovine3dom avatar Feb 23 '19 10:02 bovine3dom

Related to this - I'd like an interface to armake2 verify that checked all the signatures in a mod folder against its key.

I don't know how I'd deal with optionals/ - I'd probably leave it out of scope for now as I think there's no standard way of talking about keys for optionals.

bovine3dom avatar Feb 25 '19 10:02 bovine3dom

I think we should just do 1 command for other non-build related armake2 functionalities, something like hemtt armake2 <command> maybe? That way you could also use it in additional build steps for verification or whatever, and test armake2 stuff directly.

Problem is API I guess, we'd have to copy main argument handling, right? Or can we invoke armake2 like that directly?

Optional signs are using same key, that's the standard.

jonpas avatar Feb 25 '19 12:02 jonpas

There may be a way to call armake directly with a string, as if it was called from the command line. It might not be the most elegant but it should be possible.

BrettMayson avatar Feb 25 '19 13:02 BrettMayson

I don't quite understand your suggestions - I want to use HEMTT's knowledge of how addons are laid out so it can know which PBOs to sign or verify, where keys are stored, etc, and that it can do this in parallel in a cross platform manner.

How would we automatically know which files any armake2 command should operate on?

bovine3dom avatar Feb 25 '19 13:02 bovine3dom

Oh, I see, that's a completely separate thing then. I suggest you open a new issue, that's a pure feature request. :)

jonpas avatar Feb 25 '19 17:02 jonpas

Hmm, it's pretty related to this issue as it'd be operating on the same files. We probably want a function that walks over specific directories and applies a function to find files/directories matching some type, which would then work for lots of armake2 commands.

Otherwise splitting out the signing step is pretty trivial.

bovine3dom avatar Feb 25 '19 18:02 bovine3dom