node-docker-good-defaults icon indicating copy to clipboard operation
node-docker-good-defaults copied to clipboard

Published 20 hours ago • verified publisher icon BretFisher

Using npm@latest-7 and disabling git line ending conversion

Open istvan-ujjmeszaros opened this issue 2 years ago • 0 comments

The container doesn't seem to run with npm@latest (tried on a Windows host and a WSL Ubuntu host), latest-7 solved it for me. Also, line ending conversion was enabled on Windows by default which was causing an error with the bash script running, the conversion can be disabled with the .gitattributes file. The container is running on both Windows and WSL Ubuntu host after these tweaks.

istvan-ujjmeszaros avatar Jun 29 '22 03:06 istvan-ujjmeszaros

Hey thanks.

I would think it's better to set gitattributes per-machine rather than each repo.

I'm updating to node:16-slim which gets us npm 8.

BretFisher avatar Sep 19 '22 21:09 BretFisher