A few suggestions

Open sodiumchl opened this issue 5 years ago • 1 comments

Thanks for the script!

Here are a few suggestions: 1> /dev/null should be > /dev/null Otherwise, there is an error when running on MacOS.

Include correct email in key. Add the following in createKey(): KNAME=$(basename $KEY) grep -q '@' <<< $KNAME || KNAME=$KNAME@$HOSTNAME KEYEMAIL="-C $KNAME"

    COMMAND="$COMMAND $TYPE $BITS $KEYEMAIL $OUTPUT_DIR $PASS"

Sep 23 '20 16:09 sodiumchl

@sodiumchl thanks for the feedback mate! Feel free to submit a PR on this 😄

Sep 25 '20 06:09 BrendanThompson