Brendan

Results 29 comments of Brendan

@RAnders00 That does look like a bug (so different issue). I can see there is an internal utility (`normalize`) called to strip leading and trailing "/" characters ...but I don't...

@dnguyenlearning Sorry - I see what you mean. I can see the router decodes the query string - then writes the decoded version back into the address bar (with invalid...

To clarify _why_ the `block` function needs to be available to the router integration (in addition to the internals)... ...in the event of a navigation being blocked, the integration (path,...

If your curious, this commit (~~https://github.com/cselnz/solid-router/commit/772615038535562b619f7d63479f9df5f95fefe7~~) suggest how this new block ability might be used in the integrations. Note - I'm testing that in our apps using hash integration -...

Scrapping this in favour the much more comprehensive PR https://github.com/solidjs/solid-router/pull/186

I think the issue is the router needs to support transitions, so it doesn't want to update the browser history until after that completes. In the destination component, do you...

I suspect it was something else giving you the `Cannot read properties of undefined`. Check that the direct parent component of `` is either `` or another `` (if nesting)....

If I don't have a wrapping `` I get this in the console... ![image](https://github.com/solidjs/solid-router/assets/1744490/14cc290d-acf2-4bd7-b73e-0ae400ba072c) If I have an ErrorBoundary that logs... ```js { console.error(err); return {err}; }} > ``` ![image](https://github.com/solidjs/solid-router/assets/1744490/ecc28ec5-9ee2-4919-a323-0349b485d822)

Yep - I get those 3 logs on page refresh. I might be using a slightly older version of the router though so it is probably worth you setting one...

Curiously if you delete the ErrorBoundary you see your message. I've run out of time to look further tonight. There are quite a few differences between your project and the...