PySceneDetect icon indicating copy to clipboard operation
PySceneDetect copied to clipboard

Published 20 hours ago • verified publisher icon Breakthrough

Extend image_name_template to allow timestamp

Open Veldhoen opened this issue 2 months ago • 1 comments

Veldhoen avatar Apr 26 '24 14:04 Veldhoen

I see in your PR you've already used the $TIMESTAMP_MS format as per the discussion in #394. Would you be able to run yapf to format the resulting code so it passes the formatting checks?

Thank you for the PR!

Breakthrough avatar Apr 27 '24 23:04 Breakthrough

Thanks for replying so fast, even though my PR was still a draft. I'll make sure to address the issues you mentioned, hopefully later today.

Veldhoen avatar Apr 29 '24 08:04 Veldhoen

Rebased on develop now, and I think the formatting is in line with your standards now. Also added $TIMECODE like you suggested in the issue, and added both $TIMECODE and $FRAME_NUMBER to test_save_images.

Documentation still needs to be updated to explain these extensions.

Veldhoen avatar Apr 30 '24 08:04 Veldhoen

I applied the requested changes, and extended docstring. Hope this will do!

Veldhoen avatar May 02 '24 12:05 Veldhoen

Much appreciated, approved.

Thank you for the PR!

Breakthrough avatar May 03 '24 02:05 Breakthrough

@Breakthrough When do you plan to release 0.6.4? I created a pre-release of my fork to be able to use the functionality right away, but I'd like to use a proper release at some point, of course.

Veldhoen avatar May 06 '24 05:05 Veldhoen

I'm hoping to wrap up the next release by the end of this month. If for whatever reason you need this sooner in production, I can consider pushing a pre-release to PyPI.

Breakthrough avatar May 08 '24 01:05 Breakthrough