NLoptNet icon indicating copy to clipboard operation
NLoptNet copied to clipboard

not able to push branch

Open JohanDelvaux opened this issue 1 year ago • 2 comments

Hi BrannonKing,

I made a small extension to your library in a local branch, which I would like push to Github and create a PR, but I think I do not have permission to do so?

(According to LGPL I need to make changes public so would prefer if I can just add them here instead of creating a fork. I guess you might also make a new Nuget package available at a certain point for other to use?)

Thanks, Johan

JohanDelvaux avatar Mar 24 '23 07:03 JohanDelvaux

You need to fork the repo first. Then make a new branch in that containing your changes. Then make a pull request from that branch back into the master branch here. If the change is not applicable to general audiences, you can just keep it in your (public) fork; that is sufficient for LGPL.

BrannonKing avatar Mar 24 '23 14:03 BrannonKing

Ok BrannonKing. I created a fork and committed my changes to my master branch. (https://github.com/JohanDelvaux/NLoptNet/tree/master) I think it might be useful for other people as well although it's really quite small. Let me know if you want me to create a PR.

JohanDelvaux avatar Mar 27 '23 16:03 JohanDelvaux