SimpleTCP icon indicating copy to clipboard operation
SimpleTCP copied to clipboard

Published 20 hours ago • verified publisher icon BrandonPotter

Added interfaces to allow for mocks in unit testing

Open Scott-Lyons opened this issue 7 years ago • 3 comments

Fixes #10

Scott-Lyons avatar Apr 03 '17 08:04 Scott-Lyons

Haven't reviewed yet - you guys know if this breaks any existing usage (is this a major or minor rev)?

BrandonPotter avatar May 31 '17 15:05 BrandonPotter

Any idea when this PR is going to be merged and released?

yarimiz avatar Aug 21 '18 12:08 yarimiz

I raised this PR a while ago due to not being able to mock the SimpleTcpClient (and thus making testing more difficult). At the time I worked around this issue (rather than waiting for the merge).

As of right now I am no longer using the SimpleTcpClient and given the time taken to get this PR merged, I'm assuming it's not that much use to anyone else, so could probably be closed?

Scott-Lyons avatar Aug 22 '18 08:08 Scott-Lyons