web-branch-deep-linking-attribution icon indicating copy to clipboard operation
web-branch-deep-linking-attribution copied to clipboard

Perf() : replace jscs with eslint

Open JagadeeshKaricherla-branch opened this issue 2 years ago • 3 comments
trafficstars

Pull Request Template

Description

Replace linting tool from jscs ( package deprecated ) to eslint

Fixes # (issue)

Type of change : performance

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Unit test
  • [ ] Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

Test Results

112 tests   105 :heavy_check_mark:  56s :stopwatch:     1 suites      7 :zzz:     1 files        0 :x:

Results for commit 9a0b7705.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 14 '23 06:09 github-actions[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ce035be). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #933   +/-   ##
=========================================
  Coverage          ?   24.60%           
=========================================
  Files             ?       15           
  Lines             ?     2321           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1750           
  Partials          ?        0           

codecov[bot] avatar Sep 14 '23 06:09 codecov[bot]

Most of these changes are just from executing the eslint tool right?

gdeluna-branch avatar Sep 18 '23 08:09 gdeluna-branch