react-native-branch-deep-linking-attribution icon indicating copy to clipboard operation
react-native-branch-deep-linking-attribution copied to clipboard

Published 20 hours ago • verified publisher icon BranchMetrics

~creation_source type should be number

Open vincent-paing opened this issue 2 years ago • 1 comments

I noticed the typing for ~creation_source is wrong. It should be number instead of string. This can be verified easily by creating a deeplink from API.. Putting this into branch.subscribe and console logging event.params will tell you that ~creation_source is a number. You can also do a check like this and confirm that check returns false.

event.params[~creation_source] === '0' // false

Also by the document, these are numbers.

Where the link was created (0 API
, 1 Quick Link, 2 SDK, 3 iOS SDK
, 4 Android SDK
, 5 Web SDK, 6 Dynamic, 7 Third party)

Let me know if you want me to submit a PR to fix this.

vincent-paing avatar May 14 '22 02:05 vincent-paing

That'd be super helpful @vincent-paing . Our team will test/review it this week once published.

Thanks!

gdeluna-branch avatar May 16 '22 19:05 gdeluna-branch