react-native-branch-deep-linking-attribution icon indicating copy to clipboard operation
react-native-branch-deep-linking-attribution copied to clipboard

Published 20 hours ago • verified publisher icon BranchMetrics

Incorrect integration documentation

Open SRandazzo opened this issue 4 years ago • 1 comments

Hi,

The documentation listed here https://help.branch.io/developers-hub/docs/react-native#swift is incorrect. Select the Objective-C tab and it reads as follows: image

Highlighted portion should actually read (adding a !)

 if (![RNBranch application:app openURL:url options:options])  {
        // do other deep link routing for the Facebook SDK, Pinterest SDK, etc
  }

The example in the repo is correct and includes the !: https://github.com/BranchMetrics/react-native-branch-deep-linking-attribution/blob/a69c730ba8bdce592b222e058555c493898cba48/examples/testbed_native_ios/ios/testbed_native_ios/AppDelegate.m#L30

Thanks

SRandazzo avatar Oct 05 '20 15:10 SRandazzo

Hey! I actually agree with this issue. I was bamboozled when I was reading this.

jkadamczyk avatar Oct 05 '20 16:10 jkadamczyk