ios-branch-deep-linking-attribution icon indicating copy to clipboard operation
ios-branch-deep-linking-attribution copied to clipboard

[SDK-2328] Added API URL check for Branch.json

Open nsingh-branch opened this issue 5 months ago • 1 comments

Reference

SDK-2328 -- Support setting Branch API URL in Branch.json

Summary

Added a new field to branch.json for setting the Branch API URL. The config check and setAPIUrl call are done in Branch.m's initWithInterface() in the same place as the deferInitForPluginRuntime() and enableLogging() checks.

Motivation

To support setting the API URL in our plugins like React Native.

Type Of Change

  • [x] New feature (non-breaking change which adds functionality)

Testing Instructions

Add "apiUrl": "https://api.branch.io" to a branch.json file and observe the API URL properly change for each request.

cc @BranchMetrics/saas-sdk-devs for visibility.

nsingh-branch avatar Mar 28 '24 18:03 nsingh-branch

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 51.17%. Comparing base (1b03a81) to head (84ef9b2). Report is 12 commits behind head on master.

Files Patch % Lines
Sources/BranchSDK/Branch.m 33.33% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
- Coverage   51.27%   51.17%   -0.10%     
==========================================
  Files          66       66              
  Lines       10092    10098       +6     
  Branches     3697     3703       +6     
==========================================
- Hits         5175     5168       -7     
- Misses       4654     4661       +7     
- Partials      263      269       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 18:03 codecov[bot]