ios-branch-deep-linking-attribution icon indicating copy to clipboard operation
ios-branch-deep-linking-attribution copied to clipboard

Critical bug: branch links not resolving data

Open sethmills21 opened this issue 3 years ago • 5 comments

Describe the bug

In-app links (like app:/// instead of the full url links) are not resolving data and not being recognized by Branch as branch links even though I've taken them directly from the dashboard (link?debug=true) of the Arbor debugging tool. We believe this started happening a few weeks ago

Steps to reproduce

  1. Create a branch link with deeplink data
  2. Open deeplink on iOS with debugger open and log deeplink data
  3. Got to Branch arbor debugging tool and grab app uri
  4. Open that link -> no branch data

Expected behavior

The app URI / in app URI should also be recognized as branch link and return data

SDK Version

0.36.0

XCode Version

13.4.1

Device

iPhone 13

OS

15.6.1

Additional Information/Context

No response

sethmills21 avatar Sep 12 '22 17:09 sethmills21

I think this is a link configuration issue, rather than an SDK issue. Could you file a support ticket. https://help.branch.io/using-branch/page/submit-a-ticket

echo-branch avatar Sep 14 '22 17:09 echo-branch

I filed a support ticket and can confirm it's not a link configuration issue

sethmills21 avatar Sep 14 '22 21:09 sethmills21

Hi @sethmills21,

The Support team has been keeping me up to date.

I do want to call out, the testing steps would not produce a valid Branch Link Open.

Copying the URI scheme and pasting it in a browser url field will not result in a Branch open.

There are many reasons why this would not, but primarily to prevent phishing, click farms, etc. Especially as attributed opens affect campaign optimizations, ad spend, and marketing budgets, let alone allow for fraudulent activity.

If you want to handle in-app deep links, please utilize our handling for that: https://help.branch.io/developers-hub/docs/ios-advanced-features#handle-links-in-your-own-app

As Support may have informed you, i am more than happy to hop on a call to discuss further and help with investigations and the solution.

jf-branch avatar Sep 14 '22 22:09 jf-branch

Did you get a chance to watch the loom though? I don't paste in a browser field, I've tested it from firing in app from a button, from opening it from iMessages or notes app?

https://www.loom.com/share/b57c43b0c9f348dabc44cde072af4ed9

Again, this has actually been our workflow for years so I guess how else should we handle in-app deeplinks.

These are BUOs and I am using the deeplink handler:

On Wed, Sep 14, 2022 at 6:02 PM, Justin - Branch < @.*** > wrote:

Hi @ sethmills21 ( https://github.com/sethmills21 ) ,

The Support team has been keeping me up to date.

I do want to call out, the testing steps would not produce a valid Branch Link Open.

Copying the URI scheme and pasting it in a browser url field will not result in a Branch open.

There are many reasons why this would not, but primarily to prevent phishing, click farms, etc. Especially as attributed opens affect campaign optimizations, ad spend, and marketing budgets, let alone allow for fraudulent activity.

If you want to handle in-app deep links, please utilize our handling for that: https:/ / help. branch. io/ developers-hub/ docs/ ios-advanced-features#handle-links-in-your-own-app ( https://help.branch.io/developers-hub/docs/ios-advanced-features#handle-links-in-your-own-app )

As Support may have informed you, i am more than happy to hop on a call to discuss further and help with investigations and the solution.

— Reply to this email directly, view it on GitHub ( https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/issues/1198#issuecomment-1247345680 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AB4QXU6AS25N62ZIEUFDWV3V6JDQPANCNFSM6AAAAAAQKWGKD4 ). You are receiving this because you were mentioned. Message ID: <BranchMetrics/ios-branch-deep-linking-attribution/issues/1198/1247345680 @ github. com>

sethmills21 avatar Sep 14 '22 22:09 sethmills21

@sethmills21 I just watched the loom for the first time, it could be a matter of mismatched API keys. So your init (or api2.branch.io/v1/open) call is using your test API key (key_test) while the link is using your branch live key (key_live) We treat test and live environments totally isolated and separate, including the link data returned.

Could you share the Branch.enableLogging() logs with us? You don't have to share here, you can share with support, or email me directly at [email protected].

jf-branch avatar Sep 14 '22 22:09 jf-branch

Closing with no activity.

echo-branch avatar May 09 '23 19:05 echo-branch