cordova-ionic-phonegap-branch-deep-linking-attribution icon indicating copy to clipboard operation
cordova-ionic-phonegap-branch-deep-linking-attribution copied to clipboard

ios: Remove deployment-target

Open MaximBelov opened this issue 1 year ago • 1 comments

Reference

SDK-XXXX -- <TITLE>.

Summary

Motivation

Preference deployment-target should be defined in config.xml https://cordova.apache.org/docs/en/latest/config_ref/index.html

The value from the plugin overrides the value from config.xml

Value from config.xml should have more priority than value from the plugin

Please remove this preference and add it to the documentation. https://help.branch.io/developers-hub/docs/cordova-phonegap-ionic#configure-app

Type Of Change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

Testing Instructions

cc @BranchMetrics/saas-sdk-devs for visibility.

MaximBelov avatar Oct 16 '24 05:10 MaximBelov

Bump on this, would like this merged as it's causing issues with cordova-plugin-firebasex pods.

fluffysaur avatar May 15 '25 06:05 fluffysaur

Why is this still not merged?

AmonM avatar Sep 01 '25 13:09 AmonM