android-branch-deep-linking-attribution icon indicating copy to clipboard operation
android-branch-deep-linking-attribution copied to clipboard

Crash ConcurrentModificationException from Branch.extractAppLink

Open AlonParker opened this issue 3 years ago • 7 comments

Hello, Crashes from production: branchVersion = '5.0.3'

android.util.ArrayMap.put (ArrayMap.java:502) android.os.BaseBundle.putBoolean (BaseBundle.java:570) android.content.Intent.putExtra (Intent.java:8361) io.branch.referral.Branch.extractAppLink (Branch.java:2986) io.branch.referral.Branch.readAndStripParam (Branch.java:1087) io.branch.referral.Branch.onIntentReady (Branch.java:2088) io.branch.referral.BranchActivityLifecycleObserver.onActivityResumed (BranchActivityLifecycleObserver.java:65) android.app.Application.dispatchActivityResumed (Application.java:239) android.app.Activity.onResume (Activity.java:1343) androidx.fragment.app.FragmentActivity.onResume (FragmentActivity.java:455) moxy.MvpAppCompatActivity.onResume (MvpAppCompatActivity.java:39) android.app.Instrumentation.callActivityOnResume (Instrumentation.java:1413) android.app.Activity.performResume (Activity.java:7292) android.app.ActivityThread.performResumeActivity (ActivityThread.java:3814) android.app.ActivityThread.handleResumeActivity (ActivityThread.java:3854) android.app.servertransaction.ResumeActivityItem.execute (ResumeActivityItem.java:51) android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:145) android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:70) android.app.ActivityThread$H.handleMessage (ActivityThread.java:1816) android.os.Handler.dispatchMessage (Handler.java:106) android.os.Looper.loop (Looper.java:193) android.app.ActivityThread.main (ActivityThread.java:6735) java.lang.reflect.Method.invoke (Method.java) com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:858)

AlonParker avatar Mar 29 '21 11:03 AlonParker

Any updates on this? this crash attributes to 20% of the crashes of our last release

evgeni-shafran avatar Apr 06 '21 02:04 evgeni-shafran

Same crash, anything yet?

Kurisasa avatar Apr 15 '21 06:04 Kurisasa

Hey @AlonParker

Wanted to follow up on this and see if you were still experiencing this issue.

If so, could you help us by providing additional information so we can reproduce on our end?

Thank you, Justin

jf-branch avatar Oct 17 '21 06:10 jf-branch

Hey @jf-branch It was a long time ago, I can no longer provide additional information, maybe this is no longer relevant

AlonParker avatar Oct 17 '21 10:10 AlonParker

@jf-branch Hi! It's still there, the top crash in our production. branchVersion = '5.0.11'. What kind of information do you want?

blinkev avatar Feb 03 '22 09:02 blinkev

The same issue is in a large application with millions of users. @jf-branch

alaegin avatar Feb 18 '22 09:02 alaegin

Any update on that? Caught it a minute ago on a debug build

2022-07-15 09:56:55.434 13579-13579/com.xxx.androidapp E/AndroidRuntime: FATAL EXCEPTION: main Process: com.xxx.xxxapp, PID: 13579 java.lang.RuntimeException: Unable to resume activity {com.xxx.xxxapp/com.xxx.android.start.StartActivity}: java.util.ConcurrentModificationException at android.app.ActivityThread.performResumeActivity(ActivityThread.java:4300) at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:4332) at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:52) at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2071) at android.os.Handler.dispatchMessage(Handler.java:107) at android.os.Looper.loop(Looper.java:224) at android.app.ActivityThread.main(ActivityThread.java:7561) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:995) Caused by: java.util.ConcurrentModificationException at android.util.ArrayMap.put(ArrayMap.java:608) at android.os.BaseBundle.putBoolean(BaseBundle.java:584) at android.content.Intent.putExtra(Intent.java:8837) at io.branch.referral.Branch.extractAppLink(Branch.java:2870) at io.branch.referral.Branch.readAndStripParam(Branch.java:975) at io.branch.referral.Branch.onIntentReady(Branch.java:1979) at io.branch.referral.BranchActivityLifecycleObserver.onActivityResumed(BranchActivityLifecycleObserver.java:65) at android.app.Application.dispatchActivityResumed(Application.java:461) at android.app.Activity.dispatchActivityResumed(Activity.java:1296) at android.app.Activity.onResume(Activity.java:1833) at androidx.fragment.app.FragmentActivity.onResume(FragmentActivity.java:434) at moxy.MvpAppCompatActivity.onResume(MvpAppCompatActivity.java:39) at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1453) at android.app.Activity.performResume(Activity.java:8050) at android.app.ActivityThread.performResumeActivity(ActivityThread.java:4290) at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:4332)  at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:52)  at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:176)  at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2071)  at android.os.Handler.dispatchMessage(Handler.java:107)  at android.os.Looper.loop(Looper.java:224)  at android.app.ActivityThread.main(ActivityThread.java:7561)  at java.lang.reflect.Method.invoke(Native Method)  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:995) 

blinkev avatar Jul 15 '22 07:07 blinkev