Branch prevents removing Jetifier

[zsperske]

We're trying to remove Jetifier to improve our build times, Branch is one of the few dependencies we have left that still has old support library references.

Using the plugin at: https://github.com/dipien/bye-bye-jetifier

Scanning io.branch.sdk.android:library:5.0.5 Absoulute path: /Users/zacharysperske/.gradle/caches/modules-2/files-2.1/io.branch.sdk.android/library/5.0.5/bab5c6f5553b9e96f62707357be99af181f3ebcf/library-5.0.5.aar Graphs to this dependency: +---io.branch.sdk.android:library:5.0.5 Issues found:

• io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsClient
• io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsCallback
• io/branch/referral/BranchStrongMatchHelper.class -> android.support.customtabs.CustomTabsSession

[poldz123]

Any update on this?

[mochadwi]

+1 any update on this?

[mochadwi]

branch.io v5.0.7 still unable to disable jetifier with the same issues above found

[mochadwi]

is it possible to fork the branch.io and publish it on our private maven repository and use it as our dependencies? or is it requires extra configurations to make branch.io works when we forked it?

[mochadwi]

:( any updates?

[mattt-seek]

+1 here

[KrestM]

Any update about that?

[KennethNickles]

Any updates on this?

[KennethNickles]

I dug into the code a bit and it looks like the plugin in question https://github.com/dipien/bye-bye-jetifier is strictly doing a string search for support dependencies. Branch is actually only referencing the support lib dependencies via reflection to see if they are present in the class path.

try {
    CustomTabsClientClass = Class.forName("android.support.customtabs.CustomTabsClient");
    CustomTabsCallbackClass = Class.forName("android.support.customtabs.CustomTabsCallback");
    CustomTabsSessionClass = Class.forName("android.support.customtabs.CustomTabsSession");
    ICustomTabsServiceClass = Class.forName("android.support.customtabs.ICustomTabsService");
} catch (Exception t) {
    isCustomTabsAvailable_ = false;
}

Its not actually dependent on them

[mochadwi]

I dug into the code a bit and it looks like the plugin in question https://github.com/dipien/bye-bye-jetifier is strictly doing a string search for support dependencies. Branch is actually only referencing the support lib dependencies via reflection to see if they are present in the class path.

try {
    CustomTabsClientClass = Class.forName("android.support.customtabs.CustomTabsClient");
    CustomTabsCallbackClass = Class.forName("android.support.customtabs.CustomTabsCallback");
    CustomTabsSessionClass = Class.forName("android.support.customtabs.CustomTabsSession");
    ICustomTabsServiceClass = Class.forName("android.support.customtabs.ICustomTabsService");
} catch (Exception t) {
    isCustomTabsAvailable_ = false;
}

Its not actually dependent on them

ahh, it's safe to remove the jetifier then?

[KennethNickles]

I believe so

[mochadwi]

A question for the branch team:

Is there any concern why branch.io referencing the support lib dependencies (not an androidx libs) via reflection?

[GianfrancoMS]

+1

[dannyroa]

It seems like after this library is jetified, isCustomTabsAvailable will always be false

[mochadwi]

It seems like after this library is jetified, isCustomTabsAvailable will always be false

This the actual concern we're not sure, did we need to use Custom tabs or not via Branch. Leaves us do nothing for now! Unless official statement from branch team

[NitinPraksash9911]

any updates on this????????

[wartingep]

+1

[warting]

branch io is already using androidx and this is a false possitive report from bye bye jetifier.

use the official ./gradlew checkJetifier to see if jetifier can be removed