Session initialization already happened

[djrausch]

Hi,

Our Branch implementation has stopped working once updating from 4.0.0 to 4.3.2. We had a splash activity that launched a Main activity and the app was then a single activity app. I refactored our code to include splash in our nav graph and have a true single activity app thinking this may be part of the issue. Turns out the issue still exists.

I have followed to docs exactly, yet the Branch listener gets an error (issue title) on returning to the app (it works fine if the app is not in memory). The docs state that I am to put Branch.getInstance().initSession(branchListener, this.intent.data, this) in my onStart. That's fine, but when the activity is resumed, onStart is called again. Because of this I get no data sent to my Branch listener. However, if I kill the app and reopen the intended data flows through.

I also have

this.intent = intent
Branch.getInstance().reInitSession(this, branchListener)

in my onNewIntent()

I tried moving the initSession call to onCreate as that is only called once, but then I get initializing session on user's behalf (onActivityResumed called but SESSION_STATE = UNINITIALISED)

Any ideas? Thanks!

[jliu-branch]

  @Override
    public void onNewIntent(Intent intent) {
        this.setIntent(intent);
    }

have you tried this ^ without reInitSession?

[djrausch]

Just tried that and same result.

I did notice something interesting. When I open a branch link with the app in memory, it won't pass the params. However, if I kill the app and re-open the params are then passed.

[Taharo]

Have the same problem after update from 4.1.1 to 4.3.2. Deeplink from Google Play install doesn't work if application contains SplashActivity. If I remove SplashActivity, deeplink start to work fine, but I need to have SplashActivity.

[FaisalAli19]

Hi,

I am facing the same issue. Did you find any solution?

Thanks.

[bklastaitis-branch]

Hi all, we are having internal discussions about how to best approach this scenario. In the short term, there is a workaround that simply reverts the SDK behavior to pre v4.2.0 (to be placed in the initSession callback)

// client's code
if (error == null && referringParams != null) {
  branchReferringPramas_ = referringParams.toString()
}
// the workaround for the ERR_BRANCH_ALREADY_INITIALIZED error
if else (error.getErrorCode() == BranchError.ERR_BRANCH_ALREADY_INITIALIZED) {
  
branchReferringPramas_ = Branch.getLatestReferringParams();

}

There is more information here about how to avoid this error the proper way.

[connoremma]

Sup

FWIW this worked for me: I REMOVED this line from their documentation

 @Override
      public void onNewIntent(Intent intent) {
          super.onNewIntent(intent);
          RNBranchModule.onNewIntent(intent); // Remove this line
      }

And replaced it with this:

 @Override
    public void onNewIntent(Intent intent) {
        super.onNewIntent(intent);
        setIntent(intent); // Added this one 

     // Idk if you actually need this but it was in there when it worked
      if(intent != null) {
          intent.putExtra("branch_force_new_session", true);
      }
    }

[daviduzan]

The same happened to me and nothing seemed to help, then I saw that the Branch tutorial was quite confusing - you need the call Branch.getAutoInstance(this) on the Applications onCreate, not the Splash/other branch receiving activity. Moving it there has solved this issue.