LEGUP icon indicating copy to clipboard operation
LEGUP copied to clipboard

Tree Tent Test Suite

Open jadeandtea opened this issue 1 year ago • 2 comments

Description

Updates the Tree Tent Test suite

  • Improved FillInRow Case Rule generation
  • Test cases for TentForTree Direct Rule (incomplete)
  • Test cases for FillInRow Case Rule
  • Test cases for LinkTent Case Rule

Bug Fixes

  • Fix Puzzle Editor Functionality
  • Lines placed while solving are now saved and reopened properly
  • Allows for applying TreeTent case rules on nodes apart from the root
  • Allows for puzzles with more rows than columns

Closes #608, #609, #610, #611, #757, #768

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Enhancement (improvement to an already existing feature)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I was able to create and reopen TreeTent puzzles with various sizes. After making a few moves while solving a puzzle, placing a line, and saving the puzzle, I was able to reopen it.

Checklist:

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation (if applicable)
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

jadeandtea avatar Mar 27 '24 01:03 jadeandtea

Converting this PR to a draft since it seems to be WIP

charlestian23 avatar Mar 27 '24 17:03 charlestian23

I have no idea why the Ubuntu and Checkstyle actions are failing when loading the file for one of the FillInRowCaseRule tests. I'll just comment it out for now.

jadeandtea avatar Apr 16 '24 20:04 jadeandtea