LEGUP icon indicating copy to clipboard operation
LEGUP copied to clipboard

Color-Blind friendly UI

Open sparakala21 opened this issue 2 years ago • 5 comments

Describe the current behavior of what you're trying to improve. If your enhancement request related to a problem, please also describe the problem.

Lots of LEGUP's UI is based on things lighting up red or green. The problem with that is that color blind people(like myself) have a hard time understanding when something is wrong.

Describe the improvement you'd like

Simple fixes can include changing the contrast between the reds and greens, or switching to red and blue.

High priority changes are the proof tree, short truth table rule icons and maybe the colors on the short truth table board.

Describe alternatives you've considered

No response

Additional Context

No response

sparakala21 avatar Feb 03 '23 22:02 sparakala21

Yeah, this change would be really nice (would help me as well). I think the best thing to do is to change green to blue, but that's just my suggestion. You could probably just create a setting that lets the user choose a colorblind mode if they wanted to.

charlestian23 avatar Feb 03 '23 22:02 charlestian23

The ADA recommends against the following color combinations: Green – Blue Green – Yellow Green – Red Blue – Purple Blue – Grey Green – Brown Green – Grey Red & Blue might be a slight upgrade or maybe allow users to specify their own colors

N-Desmarais avatar Feb 07 '23 21:02 N-Desmarais

That sounds like a good idea. do you want to work on this together?

sparakala21 avatar Feb 07 '23 21:02 sparakala21

Specifying own colors would be a nice feature, though if that is too much work for you, we can stick to changing all instances of green to blue for now. Although, LEGUP might already have the color blue reserved for something, so you might have to pick a new color scheme. I'll leave the design up to you.

charlestian23 avatar Feb 07 '23 21:02 charlestian23

You can find the colors for the proof tree in: src/main/java/edu/rpi/legup/ui/proofeditorui/treeview/TreeTransitionView.java

The colors you should care about are CORRECT_COLOR and INCORRECT_COLOR, but you may want to play around with others to make things look nice

N-Desmarais avatar Feb 17 '23 21:02 N-Desmarais