Notification icon indicating copy to clipboard operation
Notification copied to clipboard

Non-admins can't edit and save recipients for notifications

Open edwinsiebel opened this issue 3 years ago • 2 comments

Bug description

You have the possibility to filter the capabilites using the notification/post_type/capabilities hook.

When you change this to a value not manage_options, the API to endpoints of /repeater-field/(?P<id>\d+), /section-repeater-field/(?P<id>\d+) or repeater-field/select are only accessible by the capability manage_options. See example.

The problem with this, when a user without the cap manage_options, and he/she edits a notification with one or more recipient repeat-fields, this user does not see the repeat-fields (a 403 response is given when fetching the fields). And when this user saves the notification, the recipients fields are not saved to the notification, which results in no recipients getting mailed.

Expected behavior

The repeated fields should be accessible to anyone who has the ability to edit notifications.

Environment

  • PHP: 7.4
  • WordPress: 5.7.2
  • Notification plugin: 7.2.4

Screenshots

Admin user: admin

Editor user: editor

edwinsiebel avatar Jun 22 '21 09:06 edwinsiebel

Thanks for the report @edwinsiebel ! This should be an easy fix. I'll make sure to attach the changelog here if you'd like to hotfix before the next release.

jakubmikita avatar Jun 22 '21 19:06 jakubmikita

Great, if you need any help, let me know

edwinsiebel avatar Jun 22 '21 20:06 edwinsiebel