matching-networks-pytorch icon indicating copy to clipboard operation
matching-networks-pytorch copied to clipboard

Seems fce are not correctly used

Open suruoxi opened this issue 7 years ago • 1 comments

In the forward function of matching_net.py, output of self.g is passed to self.lstm, but the output of self.lstm is not used.

Note the 'output' becomes 'outputs' in 'outputs = self.lstm(output)'

code line 198

        # use fce?
        if self.fce:
            outputs = self.lstm(output)

        # get similarities between support set embeddings and target
        similarites = self.dn(support_set=output[:-1], input_image=output[-1])

suruoxi avatar Jan 11 '18 06:01 suruoxi

Do you suggest then change outputs to output?

MarioProjects avatar Dec 20 '18 21:12 MarioProjects