vscode-as3mxml icon indicating copy to clipboard operation
vscode-as3mxml copied to clipboard

Issues renaming MXML attributes

Open esidegallery opened this issue 2 years ago • 2 comments

Confirmed in a fresh installation of the latest VSCode with the ActionScript & MXML extension on Windows 10 x64.

When renaming MXML element IDs from the ActionScript side, all references in the ActionScript block are renamed, but the MXML attribute is not. When renaming an ID on the MXML element itself, a notification says 'You cannot rename this element'.

When renaming an attribute referencing another value e.g. event listener or bound property, the replaced text is offset by a character, causing the MXML to break.

MXML Rename

esidegallery avatar Jul 18 '22 10:07 esidegallery

When renaming MXML element IDs from the ActionScript side, all references in the ActionScript block are renamed, but the MXML attribute is not.

Confirmed.

When renaming an ID on the MXML element itself, a notification says 'You cannot rename this element'.

Confirmed. I guess I must have forgotten implement MXML id renaming.

When renaming an attribute referencing another value e.g. event listener or bound property, the replaced text is offset by a character, causing the MXML to break.

Confirmed. This appears to be a bug in the Royale compiler that powers code intelligence. The line is correct, but the column is off by one for attribute values.

joshtynjala avatar Aug 10 '22 21:08 joshtynjala

When renaming an attribute referencing another value e.g. event listener or bound property, the replaced text is offset by a character, causing the MXML to break.

apache/royale-compiler@749763d1757b7afe759967092150b59bb520fc8c

joshtynjala avatar Aug 11 '22 16:08 joshtynjala