GPXLab icon indicating copy to clipboard operation
GPXLab copied to clipboard

Published 20 hours ago • verified publisher icon BourgeoisLab

Wrong update dialog

Open mgian opened this issue 4 years ago • 2 comments

Got an wrong update dialog, version compiled 0.8.0, got a dialog for update that point to the 0.7.0

What I've done:

  1. new pc (never used GPXLab on) with Window 10
  2. cloned repository (updated to upstream/master)
  3. compiled (64 bit if that matter)
  4. run (from QtCreator) and got the dialog that a new update is available. But the dialog point to the 0.7.0 release, while I am running the 0.8.0 from git.

Any subsequent run does not show the dialog (even if it should check for them)

Not sure is really a problem BTW. Will try to reproduce as soon as I will change (again :-( ) the PC

mgian avatar Oct 14 '20 16:10 mgian

The proposed update version is based on the official release. https://github.com/BourgeoisLab/GPXLab/releases/latest

This is currently v0.7. V0.8 is not officially released yet.

BourgeoisLab avatar Oct 14 '20 18:10 BourgeoisLab

I think I nailed it. On the first run (when there is nothing saved in the preferences) the value of mDateSince is invalid since it cannot be read from the settings.

Then the check

if (dtPublished > mDateSince)

in the method

bool Dialog_CheckUpdate::parseReplyGithub(const QByteArray& str)

always return True, so the dialog is showed, even if probably is not necessary.

mgian avatar Oct 15 '20 14:10 mgian