python-luxtronik
python-luxtronik copied to clipboard
Bouni
New pypi release
Hello heatpump lovers, heating season is near. Although my time is short, I would like to advance the new code base of the HA component. If someone would like to support, you can install the preview or make code review for the core module.
For the new code I use luxtronik==0.3.14 and the new functions with an own Luxtronik class. (But time.sleep is not allowed in a core module...)
It would be great if we could get a new stable version here that I can then use. What is missing for a new stable version?
Sorry about the additional ping @Bouni or @kbabioch, but I'm also really looking forward to a new pypi release. Can we help in some way to get that going?
Yes, this would be nice. But I think that there are some issues which should be addressed before a new release, e.g., #132 and maybe also #135?
@Bouni or @kbabioch sorry to bother you folks, but is there some way to get the new pypi release made?
Hey everyone, sorry for the long silence from my side but personal things had (still have) priority over hobby projects 😓 I actually lost tack of what we added after 0.3.14 and whats necessary to release a stable 0.3.15 or even a 0.4.0
@kbabioch @gerw @BenPru what do you guys think is necessry for a new release. Can we might just release a intermediate 0.3.15 version now and a lets say 0.4.0 when the features are complete we inteded for the next "big" release?
Yes, I think 0.3.15 could be a good next step. I think we should have a further look at #132, since the issue discussed there is a significant change to the API w.r.t. 0.3.14.
@gerw Do you think #132 is a must have for a 0.3.15 release?
If not I would like to release 0.3.15 and we can plan on having #132 for the 0.3.16 or whatever release in the future.
@Bouni At least we should discuss, how we handle that issue. Currently, main has a breaking API change compared to 0.3.14 and that issue proposes to revert this breaking change. From my point of view, it does not make sense to release 0.3.15 with this braking change and then revert it in 0.3.16.
[The API change is that parameters is no longer a member of Luxtronik. Instead read() returns the parameters.]
@Bouni Now, #163 is almost finished. After merging, I propose to deal with #128 (should be a quick one). It would also be nice, to start a basic changelog, see #135.
Actually, what has been changed since 0.3.14?
- Identified datatype of many parameters / calculations
- Internal refactoring
- The connection to the heat pump is reused (instead of connect & disconnect for each read/write operation)
- TBD: New way to access the software version (#128)
I guess we have to do the changelog for a new version manually this time. Afterwards I tend to introduce commitlint / conventionalcommits to ensure commit messages that allow for a semi-automatic changelog generation.
What do you guys think about this?
Guzz-T found some incompatibilities to 0.3.14 in #132. These should also mentioned in the change log.
I have no experience with this, but we could try conventionalcommits. Do I get it right, that every commit will end up in the change log?
I took the liberty to create a new milestone for the next release. This way we can focus on the necessary changes to publish the release in the next time.